Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@remotion/lambda: Allow configuring a VPC #3881

Merged
merged 4 commits into from
May 18, 2024

Conversation

timello
Copy link

@timello timello commented May 17, 2024

Add VPC config support so remotion render lambda can download assets internally from the VPC.

With the VPC config option, the assets can be downloaded via an internal endpoint. That increases security and allows cost reduction. One clear use case is downloading assets from an S3 private bucket via an S3 VPC endpoint.

Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
bugs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 11:18pm
remotion ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 11:18pm

@JonnyBurger
Copy link
Member

Thanks a lot for this! This was done super carefully, which I appreciate a lot!

Does this already unlock additional functionality! Remotion Lambda only downloads via HTTP, or have you tricked it into doing something different? Or do you pass the internal endpoint as the src for assets?

I know the internal endpoint is interesting, and we might allow proxying S3 assets natively in the future.

@JonnyBurger
Copy link
Member

I'm just curious what exactly you are doing.
Leave the test failures, I will solve this!

@JonnyBurger JonnyBurger changed the title Add vpc config support @remotion/lambda: Allow configuring a VPC May 18, 2024
@timello
Copy link
Author

timello commented May 27, 2024

Thanks a lot for this! This was done super carefully, which I appreciate a lot!

Does this already unlock additional functionality! Remotion Lambda only downloads via HTTP, or have you tricked it into doing something different? Or do you pass the internal endpoint as the src for assets?

I know the internal endpoint is interesting, and we might allow proxying S3 assets natively in the future.

Indeed, @JonnyBurger , we do use internal endpoints as the src for assets to avoid significant expenses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants