feat(form-data): allow passing a form to FormData #26
Conversation
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
🦋 Changeset detectedLatest commit: 31a3c7d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mcansh
force-pushed
the
logan/formdata
branch
from
93c70c4
to
72bfb03
Compare
Signed-off-by: Logan McAnsh <logan@mcan.sh>
mcansh
force-pushed
the
logan/formdata
branch
from
72bfb03
to
48887cb
Compare
| * @param {Element} element | ||
| * @returns {element is HTMLSelectElement} | ||
| */ | ||
| function isSelectElement(element) { |
There was a problem hiding this comment.
these are only used once, might as well inline them?
There was a problem hiding this comment.
doing so loses out on some type checking as it doesn't do a element is HTMLSelectElement assertion anymore Property 'value' does not exist on type 'Element'. :/
There was a problem hiding this comment.
i felt a jsdoc to typescript migration was a little 🤏 outside of the scope of this PR haha
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
Signed-off-by: Logan McAnsh <logan@mcan.sh>
| @@ -259,4 +259,28 @@ export const test = (test) => { | |||
| "rename.md" | |||
| ); | |||
| }); | |||
|
|
|||
| test("Should allow passing a form element", () => { | |||
There was a problem hiding this comment.
Let's drop the jsdom dev dependency and just make our own mock HTMLFormElement that's got all the right methods/getters/etc. that we use.
| @@ -7,7 +7,7 @@ import { assert } from "./test.js"; | |||
| * @param {import('./test').Test} test | |||
| */ | |||
| export const test = (test) => { | |||
| test("test baisc", async () => { | |||
Signed-off-by: Logan McAnsh <logan@mcan.sh>
| checked: true, | ||
| } | ||
| ] | ||
| }; |
There was a problem hiding this comment.
We need Object.prototype.toString.call(value) === "[object HTMLFormElement]"; to evaluate correctly.
class FakeForm {
get [Symbol.toStringTag]() {
return "HTMLFormElement";
}
get elements() {
return [/* ... */]
}
get id() {
return "my-form"
}
}
let form = new FakeForm();https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Symbol/toStringTag
Signed-off-by: Logan McAnsh <logan@mcan.sh>
mcansh
force-pushed
the
logan/formdata
branch
from
54484a9
to
1b0c009
Compare
Signed-off-by: Logan McAnsh <logan@mcan.sh>
mcansh
force-pushed
the
logan/formdata
branch
from
5f92aee
to
2af3c8d
Compare
Signed-off-by: Logan McAnsh <logan@mcan.sh>
mcansh
force-pushed
the
logan/formdata
branch
from
2af3c8d
to
31a3c7d
Compare
No description provided.