chore: let @typescript-eslint/no-floating-promises ESLint rule pass

[ngbrown]

Summary of changes

This is just the relevant parts of the code changes from #6325 instead of also tackling eslint-config changes.

• Added void operator to Promises that are not being awaited. Used await on finally retry in test.

Details

When enabling the typescript-eslint rules contained in "plugin:@typescript-eslint/recommended-requiring-type-checking" I tried to improve code quality by addressing some of the issues raised when enabling the type checked linting rules.

This change specifically resolves issues raised with the typescript-eslint error: no-floating-promises.

error Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the void operator @typescript-eslint/no-floating-promises

Testing Strategy:

I opened up my windows machine and ran this script (with the additional eslint rules enabled from #6325):

yarn lint
yarn test:primary
npx playwrite install
yarn test
yarn build --tsc

The specific rule configuration was:

  "@typescript-eslint/no-floating-promises": [
    "error",
    { ignoreVoid: true, ignoreIIFE: true },
  ],

[changeset-bot]

⚠️ No Changeset found

Latest commit: c4a362c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[machour]

I don't think this needs a changeset since it's internal cosmetics

[remix-cla-bot]

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

[pcattori]

#6325 was closed w/o merging in favor of #6248 , so (I think) this PR is obsolete now. @ngbrown let me know if there's a reason to reopen it.

[ngbrown]

@pcattori This made code changes that #6248 didn't make, specifically the fix to withApp.ts#L39 is a test runtime behavior improvement.

There were no eslint rule changes in this pull request. I think this pull request should be re-opened.

[JoshuaKGoldberg]

@MichaelDeBoey just checking in, is there anything else left on this PR?

I'm working on the other recommended typed rules from typescript-eslint and saw this one is still hanging around.

[pcattori]

LGTM, just needs conflicts with dev to be resolved

[ngbrown]

I've rebased the branch, re-ran the no-floating-promises rule, and updated where there were new errors.

[brophdawg11]

Sorry it looks like this has new conflicts 😬 . I merged dev in locally but don't have access right to push to your fork

[ngbrown]

@brophdawg11 I re-resolved the conflicts and made sure formatting was applied to components.tsx this time.

Because I forked into a separate org, to organize my GitHub forks, I don't have the option to enable maintainers to push to the branch. I didn't realize that was a drawback at the time.

[github-actions]

🤖 Hello there,

We just published version v0.0.0-nightly-b1149bb-20230810 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!