Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code and interface improvements after enabling some eslint recommended rules requiring type checking #6325

Closed
wants to merge 11 commits into from
Closed

Code and interface improvements after enabling some eslint recommended rules requiring type checking #6325

wants to merge 11 commits into from

Commits on May 6, 2023

  1. Update contributors.yml

    @ngbrown
    ngbrown committed May 6, 2023
    Configuration menu
    Copy the full SHA
    cf20cd7 View commit details
    Browse the repository at this point in the history

  2. feat: add eslint rules that require type checking

    @ngbrown
    ngbrown committed May 6, 2023
    Configuration menu
    Copy the full SHA
    8e8ca41 View commit details
    Browse the repository at this point in the history

  3. chore: turn on @typescript-eslint/unbound-method as warning

    @ngbrown
    ngbrown committed May 6, 2023
    Configuration menu
    Copy the full SHA
    9a477c9 View commit details
    Browse the repository at this point in the history

  4. fix: Resolve 10 lint errors by adding this: void to sessions.ts. Up… 

    …date @types/react-dom to fixes 26 more lint errors.

error  Avoid referencing unbound methods which may cause unintentional scoping of `this`.

If your function does not access `this`, you can annotate it with `this: void`, or consider using an arrow function instead @typescript-eslint/unbound-method
    @ngbrown
    ngbrown committed May 6, 2023
    Configuration menu
    Copy the full SHA
    db45f18 View commit details
    Browse the repository at this point in the history

  5. chore: Add note to stream.ts about constructor bound functions causin… 

    …g unbound-method warning
    @ngbrown
    ngbrown committed May 6, 2023
    Configuration menu
    Copy the full SHA
    5ab2a13 View commit details
    Browse the repository at this point in the history

  6. chore: turn on @typescript-eslint/no-floating-promises as error

    @ngbrown
    ngbrown committed May 6, 2023
    Configuration menu
    Copy the full SHA
    b1b2370 View commit details
    Browse the repository at this point in the history

  7. fix: Resolve 6 lint errors by using the void operator 

    error  Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator  @typescript-eslint/no-floating-promises
    @ngbrown
    ngbrown committed May 6, 2023
    Configuration menu
    Copy the full SHA
    10f293c View commit details
    Browse the repository at this point in the history

  8. fix: Resolve 1 lint error by adding await to retry() method in test 

    error  Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator  @typescript-eslint/no-floating-promises
    @ngbrown
    ngbrown committed May 6, 2023
    Configuration menu
    Copy the full SHA
    03569e3 View commit details
    Browse the repository at this point in the history

  9. chore: turn on @typescript-eslint/await-thenable as error

    @ngbrown
    ngbrown committed May 6, 2023
    Configuration menu
    Copy the full SHA
    aa52f1f View commit details
    Browse the repository at this point in the history

  10. fix: Resolve 7 lint errors by removing await from file.slice() ca… 

    …lls.

error  Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator  @typescript-eslint/no-floating-promises
    @ngbrown
    ngbrown committed May 6, 2023
    Configuration menu
    Copy the full SHA
    206d613 View commit details
    Browse the repository at this point in the history

  11. chore: add changesets

    @ngbrown
    ngbrown committed May 6, 2023
    Configuration menu
    Copy the full SHA
    c901bf2 View commit details
    Browse the repository at this point in the history