Add integration tests for request structures #4829
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@remix-run/server-runtime": patch | ||
| --- | ||
|
|
||
| - Ensure `loader` `request`'s proxy headers on document `action` submissions | ||
| - Fix an issue where loader `request`'s reflected `method: "POST"` on document submissions |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@remix-run/server-runtime": patch | ||
| --- | ||
|
|
||
| Fix error boundary tracking for multiple errors bubbling to the same boundary |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,162 @@ | ||
| import { test, expect } from "@playwright/test"; | ||
|
|
||
| import { PlaywrightFixture } from "./helpers/playwright-fixture"; | ||
| import type { Fixture, AppFixture } from "./helpers/create-fixture"; | ||
| import { createAppFixture, createFixture, js } from "./helpers/create-fixture"; | ||
|
|
||
| let fixture: Fixture; | ||
| let appFixture: AppFixture; | ||
|
|
||
| test.beforeAll(async () => { | ||
| fixture = await createFixture({ | ||
| files: { | ||
| "app/routes/index.jsx": js` | ||
| import { json } from "@remix-run/node"; | ||
| import { Form, useLoaderData, useActionData } from "@remix-run/react"; | ||
| export async function loader({ request }) { | ||
| let text = (await request.text()); | ||
| return json({ | ||
| method: request.method, | ||
| url: request.url, | ||
| headers: Object.fromEntries(request.headers.entries()), | ||
| text, | ||
| }); | ||
| } | ||
| export async function action({ request }) { | ||
| let text = (await request.text()); | ||
| return json({ | ||
| method: request.method, | ||
| url: request.url, | ||
| headers: Object.fromEntries(request.headers.entries()), | ||
| text, | ||
| }); | ||
| } | ||
| export default function Index() { | ||
| let loaderData = useLoaderData(); | ||
| let actionData = useActionData(); | ||
| return ( | ||
| <div> | ||
| <button id="set-cookie" onClick={() => { | ||
| document.cookie = 'cookie=nomnom; path=/'; | ||
| }}> | ||
| Set Cookie | ||
| </button> | ||
| <Form method="get" reloadDocument> | ||
| <button type="submit" id="submit-get-ssr" name="type" value="ssr" /> | ||
| </Form> | ||
| <Form method="get"> | ||
| <button type="submit" id="submit-get-csr" name="type" value="csr" /> | ||
| </Form> | ||
| <Form method="post" reloadDocument> | ||
| <button type="submit" id="submit-post-ssr" name="type" value="ssr" /> | ||
| </Form> | ||
| <Form method="post"> | ||
| <button type="submit" id="submit-post-csr" name="type" value="csr" /> | ||
| </Form> | ||
| <pre id="loader-data">{JSON.stringify(loaderData)}</pre> | ||
| {actionData ? | ||
| <pre id="action-data">{JSON.stringify(actionData)}</pre> : | ||
| null} | ||
| </div> | ||
| ) | ||
| } | ||
| `, | ||
| }, | ||
| }); | ||
|
|
||
| appFixture = await createAppFixture(fixture); | ||
| }); | ||
|
|
||
| test.afterAll(() => appFixture.close()); | ||
|
|
||
| test("loader request on SSR GET requests", async ({ page }) => { | ||
| let app = new PlaywrightFixture(appFixture, page); | ||
| await app.goto("/"); | ||
| await app.clickElement("#set-cookie"); | ||
|
|
||
| let loaderData = JSON.parse(await page.locator("#loader-data").innerHTML()); | ||
| expect(loaderData.method).toEqual("GET"); | ||
| expect(loaderData.url).toMatch(/^http:\/\/localhost:\d+\/$/); | ||
| expect(loaderData.headers.cookie).toEqual(undefined); | ||
| expect(loaderData.text).toEqual(""); | ||
|
|
||
| await app.clickElement("#submit-get-ssr"); | ||
|
|
||
| loaderData = JSON.parse(await page.locator("#loader-data").innerHTML()); | ||
| expect(loaderData.method).toEqual("GET"); | ||
| expect(loaderData.url).toMatch(/^http:\/\/localhost:\d+\/\?type=ssr$/); | ||
| expect(loaderData.headers.cookie).toEqual("cookie=nomnom"); | ||
| expect(loaderData.text).toEqual(""); | ||
| }); | ||
|
|
||
| test("loader request on CSR GET requests", async ({ page }) => { | ||
| let app = new PlaywrightFixture(appFixture, page); | ||
| await app.goto("/"); | ||
| await app.clickElement("#set-cookie"); | ||
|
|
||
| let loaderData = JSON.parse(await page.locator("#loader-data").innerHTML()); | ||
| expect(loaderData.method).toEqual("GET"); | ||
| expect(loaderData.url).toMatch(/^http:\/\/localhost:\d+\/$/); | ||
| expect(loaderData.headers.cookie).toEqual(undefined); | ||
| expect(loaderData.text).toEqual(""); | ||
|
|
||
| await app.clickElement("#submit-get-csr"); | ||
|
|
||
| loaderData = JSON.parse(await page.locator("#loader-data").innerHTML()); | ||
| expect(loaderData.method).toEqual("GET"); | ||
| expect(loaderData.url).toMatch(/^http:\/\/localhost:\d+\/\?type=csr$/); | ||
| expect(loaderData.headers.cookie).toEqual("cookie=nomnom"); | ||
| expect(loaderData.text).toEqual(""); | ||
| }); | ||
|
|
||
| test("action + loader requests SSR POST requests", async ({ page }) => { | ||
| let app = new PlaywrightFixture(appFixture, page); | ||
| await app.goto("/"); | ||
| await app.clickElement("#set-cookie"); | ||
|
|
||
| let loaderData = JSON.parse(await page.locator("#loader-data").innerHTML()); | ||
| expect(loaderData.method).toEqual("GET"); | ||
| expect(loaderData.url).toMatch(/^http:\/\/localhost:\d+\/$/); | ||
| expect(loaderData.headers.cookie).toEqual(undefined); | ||
| expect(loaderData.text).toEqual(""); | ||
|
|
||
| await app.clickElement("#submit-post-ssr"); | ||
|
|
||
| let actionData = JSON.parse(await page.locator("#action-data").innerHTML()); | ||
| expect(actionData.method).toEqual("POST"); | ||
| expect(actionData.url).toMatch(/^http:\/\/localhost:\d+\/$/); | ||
| expect(actionData.headers.cookie).toEqual("cookie=nomnom"); | ||
| expect(actionData.text).toEqual("type=ssr"); | ||
|
|
||
| loaderData = JSON.parse(await page.locator("#loader-data").innerHTML()); | ||
| expect(loaderData.method).toEqual("GET"); | ||
|
There was a problem hiding this comment. Loaders receive |
||
| expect(loaderData.url).toMatch(/^http:\/\/localhost:\d+\/$/); | ||
| expect(loaderData.headers.cookie).toEqual("cookie=nomnom"); | ||
| expect(loaderData.text).toEqual(""); | ||
| }); | ||
|
|
||
| test("action + loader requests on CSR POST requests", async ({ page }) => { | ||
| let app = new PlaywrightFixture(appFixture, page); | ||
| await app.goto("/"); | ||
| await app.clickElement("#set-cookie"); | ||
|
|
||
| let loaderData = JSON.parse(await page.locator("#loader-data").innerHTML()); | ||
| expect(loaderData.method).toEqual("GET"); | ||
| expect(loaderData.url).toMatch(/^http:\/\/localhost:\d+\/$/); | ||
| expect(loaderData.headers.cookie).toEqual(undefined); | ||
| expect(loaderData.text).toEqual(""); | ||
|
|
||
| await app.clickElement("#submit-post-csr"); | ||
|
|
||
| let actionData = JSON.parse(await page.locator("#action-data").innerHTML()); | ||
| expect(actionData.method).toEqual("POST"); | ||
| expect(actionData.url).toMatch(/^http:\/\/localhost:\d+\/$/); | ||
| expect(actionData.headers.cookie).toEqual("cookie=nomnom"); | ||
| expect(actionData.text).toEqual("type=csr"); | ||
|
|
||
| loaderData = JSON.parse(await page.locator("#loader-data").innerHTML()); | ||
| expect(loaderData.method).toEqual("GET"); | ||
| expect(loaderData.url).toMatch(/^http:\/\/localhost:\d+\/$/); | ||
| expect(loaderData.headers.cookie).toEqual("cookie=nomnom"); | ||
| expect(loaderData.text).toEqual(""); | ||
|
Comment on lines
+157
to
+161
There was a problem hiding this comment. During SPA submissions, the loader is called through separate revalidation I think this all makes sense given how Remix is executing loaders differently in MPA/SPA calls, even if it introduces a slight different between them from a DX standpoint. Users shouldn't be branching on There was a problem hiding this comment. This logic is implemented in the router here: remix-run/react-router#9721 |
||
| }); | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parent throws 401, child throws 404