Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): Add missing type def for future value in @remix-run/dev/server-build #4771

Merged
merged 1 commit into from Dec 5, 2022

Conversation

chaance
Copy link
Collaborator

@chaance chaance commented Dec 5, 2022

This should fix #4766. Unrelated to #4759.

Changeset will be added to the release branch @brophdawg11 started. Aiming to cut a hotfix shortly.

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2022

🦋 Changeset detected

Latest commit: 3287bbd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/dev Patch
create-remix Patch
remix Patch
@remix-run/architect Patch
@remix-run/cloudflare Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/deno Patch
@remix-run/eslint-config Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/node Patch
@remix-run/react Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/vercel Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MichaelDeBoey
Copy link
Member

MichaelDeBoey commented Dec 5, 2022

I think this should go to dev branch instead of main? 🤔
Or does remix-run/react-router#9679 apply here as well?

@chaance
Copy link
Collaborator Author

chaance commented Dec 5, 2022

I think this should go to dev branch instead of main? 🤔

Hot-fixes actually go to main to avoid releasing other work on dev early. We need to prioritize this fix along with some router stuff @brophdawg11 is finishing up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Property 'future' is missing in type 'typeof import("./node_modules/@remix-run/dev/server-build")'
3 participants