Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tutorials/blog): update links to MDN docs for Request and Request.formData #4767

Merged
merged 5 commits into from Dec 5, 2022
Merged

Conversation

pmbanugo
Copy link
Contributor

@pmbanugo pmbanugo commented Dec 4, 2022

Update links to the MDN docs because the current links produce redirects and I end up in a duckduckgo search page. The video below shows how to reproduce it.

Screen.Recording.2022-12-04.at.23.11.53.mov

My change adds an info section to make it readable and also open the links in a new page without too many redirects.

@changeset-bot
Copy link

changeset-bot bot commented Dec 4, 2022

⚠️ No Changeset found

Latest commit: b8526d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 4, 2022

Hi @pmbanugo,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 4, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

Copy link
Collaborator

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your submission.

Can you keep the markdown format and substitute old urls with new ones?

@pmbanugo
Copy link
Contributor Author

pmbanugo commented Dec 5, 2022

@machour I've changed it.

@pmbanugo pmbanugo requested a review from machour December 5, 2022 07:37
docs/tutorials/blog.md Outdated Show resolved Hide resolved
docs/tutorials/blog.md Outdated Show resolved Hide resolved
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
@machour
Copy link
Collaborator

machour commented Dec 5, 2022

@pmbanugo As requested above, you still need to update the references here :

-In HTML an input's `name` attribute is sent over the network and available by the same name on the request's `formData`. Oh, and don't forget, the `request` and `formData` objects are both straight out of the web specification. So if you want to learn more about either of them, head over to MDN! [mdn.io/Request][mdn-io-request] [mdn.io/Request.formData][mdn-io-request-form-data].
+In HTML an input's `name` attribute is sent over the network and available by the same name on the request's `formData`. Oh, and don't forget, the `request` and `formData` objects are both straight out of the web specification. So if you want to learn more about either of them, head over to MDN! [Request][mdn-request] [Request.formData][mdn-request-form-data].

@pmbanugo pmbanugo requested review from machour and MichaelDeBoey and removed request for MichaelDeBoey and machour December 5, 2022 14:42
docs/tutorials/blog.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@machour machour merged commit 1a132bb into remix-run:main Dec 5, 2022
@pmbanugo pmbanugo deleted the patch-1 branch December 5, 2022 18:59
kentcdodds pushed a commit that referenced this pull request Dec 15, 2022
…t.formData (#4767)

* docs(tutorials/blog): update links to MDN docs for Request

* chore: add pmbanugo to contributor list

* docs: remove -io from link text

Co-authored-by: Michaël De Boey <info@michaeldeboey.be>

* Update blog.md

* Update docs/tutorials/blog.md

Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
Co-authored-by: Mehdi Achour <machour@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants