New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(tutorials/blog): update links to MDN docs for Request and Request.formData #4767
Conversation
|
Hi @pmbanugo, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your submission.
Can you keep the markdown format and substitute old urls with new ones?
@machour I've changed it. |
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
@pmbanugo As requested above, you still need to update the references here : -In HTML an input's `name` attribute is sent over the network and available by the same name on the request's `formData`. Oh, and don't forget, the `request` and `formData` objects are both straight out of the web specification. So if you want to learn more about either of them, head over to MDN! [mdn.io/Request][mdn-io-request] [mdn.io/Request.formData][mdn-io-request-form-data].
+In HTML an input's `name` attribute is sent over the network and available by the same name on the request's `formData`. Oh, and don't forget, the `request` and `formData` objects are both straight out of the web specification. So if you want to learn more about either of them, head over to MDN! [Request][mdn-request] [Request.formData][mdn-request-form-data]. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
…t.formData (#4767) * docs(tutorials/blog): update links to MDN docs for Request * chore: add pmbanugo to contributor list * docs: remove -io from link text Co-authored-by: Michaël De Boey <info@michaeldeboey.be> * Update blog.md * Update docs/tutorials/blog.md Co-authored-by: Michaël De Boey <info@michaeldeboey.be> Co-authored-by: Mehdi Achour <machour@gmail.com>
Update links to the MDN docs because the current links produce redirects and I end up in a duckduckgo search page. The video below shows how to reproduce it.
Screen.Recording.2022-12-04.at.23.11.53.mov
My change adds an info section to make it readable and also open the links in a new page without too many redirects.