fix: Integration test for external redirects #4627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redirect('https://www.google.com/') should go to http://www.google.com/
We should not prepend the request origin to the destination URL if they
are external.
|
2 tasks
|
Keeping this here for now so we don't lose the integration test. Once remix-run/react-router#9590 is merged we can copy the updated router code over |
|
@brophdawg11 reminder for this one |
kentcdodds
pushed a commit
that referenced
this pull request
Dec 15, 2022
* Respect redirects to external url destinations
redirect('https://www.google.com/') should go to http://www.google.com/
We should not prepend the request origin to the destination URL if they
are external.
* Sign CLA
* Revert change to router utils
Co-authored-by: Anthony Powell <anthonypowell@hey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked the integration test from #4579