Respect redirects to external url destinations

contributors.yml

@@ -62,6 +62,7 @@
 - camiaei
 - CanRau
 - ccssmnn
+- cephalization
 - chaance
 - chenc041
 - chenxsan

integration/redirects-test.ts

@@ -144,6 +144,12 @@ test.describe("redirects", () => {
             return <h1>Page 2</h1>
           }
         `,
+        [`app/routes/loader/external.js`]: js`
+          import { redirect } from "@remix-run/node";
+          export const loader = () => {
+            return redirect("https://www.google.com/");
+          }
+        `,
       },
     });
 
@@ -186,4 +192,11 @@ test.describe("redirects", () => {
     // Loader called twice
     await page.waitForSelector(`#count:has-text("3")`);
   });
+
+  test("redirects to external URLs", async ({ page }) => {
+    let app = new PlaywrightFixture(appFixture, page);
+
+    await app.waitForNetworkAfter(() => app.goto("/loader/external"));
+    expect(app.page.url()).toBe("https://www.google.com/");
+  });
 });

packages/remix-server-runtime/router/utils.ts

@@ -817,7 +817,8 @@ export function resolvePath(to: To, fromPathname = "/"): Path {
   } = typeof to === "string" ? parsePath(to) : to;
 
   let pathname = toPathname
-    ? toPathname.startsWith("/")
+    ? // we don't want to prepend the fromPathname on root or external toPathnames'
+      toPathname.startsWith("/") || toPathname.startsWith("http")
       ? toPathname
       : resolvePathname(toPathname, fromPathname)
     : fromPathname;