fix(remix-react): fix attributes for namespaced Open Graph and Facebook meta tags #4445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d5c68c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
awaiting release
|
🤖 Hello there, We just published version Thanks! |
MichaelDeBoey
changed the title
This was referenced Nov 1, 2022
kentcdodds
pushed a commit
that referenced
this pull request
Dec 15, 2022
* fix(meta): use 'property' instead of 'name' for namespaced og: tags * fix(meta): make og checks more robust * chore: add changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metamisses a few cases when checking for OG meta, rendering<meta name>instead of<meta property>for those tags. This PR fixes that.I also added semi-related tests for nested route cases just to make the
metatests cover a bit more ground.