New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(templates/deno): fix type re-export from @remix-run/server-runtime
#4287
Conversation
|
Hi @wangbinyq, Welcome, and thank you for contributing to Remix! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
@remix-run/server-runtime
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@wangbinyq can you tell where you see this error?
Import directly from @remix-run/server-runtime
is a bad practice, you should import from @remix-run/deno
instead
@MichaelDeBoey It is not about import |
…me` (remix-run#4287) * fix(remix-deno): deno fix type reexport from server-runtime not working * Update contributors.yml
…me` (#4287) * fix(remix-deno): deno fix type reexport from server-runtime not working * Update contributors.yml
fix(remix-deno): deno fix type reexport from server-runtime not working