Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(templates/deno): fix type re-export from @remix-run/server-runtime #4287

Merged
merged 2 commits into from Oct 27, 2022

Conversation

wangbinyq
Copy link
Contributor

fix(remix-deno): deno fix type reexport from server-runtime not working

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2022

⚠️ No Changeset found

Latest commit: 9c097bd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 28, 2022

Hi @wangbinyq,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Sep 28, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title fix(remix-deno): deno fix type reexport from server-runtime not working fix(templates/deno): fix type re-export from @remix-run/server-runtime Oct 27, 2022
Copy link
Member

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wangbinyq can you tell where you see this error?

Import directly from @remix-run/server-runtime is a bad practice, you should import from @remix-run/deno instead

@wangbinyq
Copy link
Contributor Author

@MichaelDeBoey It is not about import @remix-run/server-runtime, It is that deno lsp dont provide type info imported from @remix-run/deno which is reexport from @remix-run/server-runtime.

no @remix-run/server-runtime
image

@remix-run/server-runtime included
image

@pcattori pcattori merged commit 243d7ad into remix-run:main Oct 27, 2022
midgleyc pushed a commit to midgleyc/remix that referenced this pull request Nov 15, 2022
…me` (remix-run#4287)

* fix(remix-deno): deno fix type reexport from server-runtime not working

* Update contributors.yml
kentcdodds pushed a commit that referenced this pull request Dec 15, 2022
…me` (#4287)

* fix(remix-deno): deno fix type reexport from server-runtime not working

* Update contributors.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants