Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix netlify/architect node 14 tests with AbortController polyfill #4169

Merged
merged 1 commit into from
Sep 11, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 1 addition & 7 deletions packages/remix-architect/__tests__/server-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -290,13 +290,7 @@ describe("architect createRemixRequest", () => {
"method": "GET",
"parsedURL": "https://localhost:3333/",
"redirect": "follow",
"signal": AbortSignal {
Symbol(kEvents): Map {},
Symbol(events.maxEventTargetListeners): 10,
Symbol(events.maxEventTargetListenersWarned): false,
Symbol(kAborted): false,
Symbol(kReason): undefined,
},
"signal": AbortSignal {},
},
}
`);
Expand Down
8 changes: 6 additions & 2 deletions packages/remix-architect/server.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
import type {
AppLoadContext,
ServerBuild,
RequestInit as NodeRequestInit,
Response as NodeResponse,
} from "@remix-run/node";
import {
AbortController as NodeAbortController,
Headers as NodeHeaders,
Request as NodeRequest,
createRequestHandler as createRemixRequestHandler,
Expand Down Expand Up @@ -66,12 +68,14 @@ export function createRemixRequest(event: APIGatewayProxyEventV2): NodeRequest {
);
// Note: No current way to abort these for Architect, but our router expects
// requests to contain a signal so it can detect aborted requests
let controller = new AbortController();
let controller = new NodeAbortController();

return new NodeRequest(url.href, {
method: event.requestContext.http.method,
headers: createRemixHeaders(event.headers, event.cookies),
signal: controller.signal,
// Cast until reason/throwIfAborted added
// https://github.com/mysticatea/abort-controller/issues/36
signal: controller.signal as NodeRequestInit["signal"],
body:
event.body && event.isBase64Encoded
? isFormData
Expand Down
6 changes: 4 additions & 2 deletions packages/remix-express/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import type {
Response as NodeResponse,
} from "@remix-run/node";
import {
AbortController,
AbortController as NodeAbortController,
createRequestHandler as createRemixRequestHandler,
Headers as NodeHeaders,
Request as NodeRequest,
Expand Down Expand Up @@ -97,12 +97,14 @@ export function createRemixRequest(
let url = new URL(req.url, origin);

// Abort action/loaders once we can no longer write a response
let controller = new AbortController();
let controller = new NodeAbortController();
res.on("close", () => controller.abort());

let init: NodeRequestInit = {
method: req.method,
headers: createRemixHeaders(req.headers),
// Cast until reason/throwIfAborted added
// https://github.com/mysticatea/abort-controller/issues/36
signal: controller.signal as NodeRequestInit["signal"],
};

Expand Down
8 changes: 1 addition & 7 deletions packages/remix-netlify/__tests__/server-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -271,13 +271,7 @@ describe("netlify createRemixRequest", () => {
"method": "GET",
"parsedURL": "http://localhost:3000/",
"redirect": "follow",
"signal": AbortSignal {
Symbol(kEvents): Map {},
Symbol(events.maxEventTargetListeners): 10,
Symbol(events.maxEventTargetListenersWarned): false,
Symbol(kAborted): false,
Symbol(kReason): undefined,
},
"signal": AbortSignal {},
},
}
`);
Expand Down
19 changes: 11 additions & 8 deletions packages/remix-netlify/server.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
import type {
AppLoadContext,
ServerBuild,
RequestInit as NodeRequestInit,
Response as NodeResponse,
} from "@remix-run/node";
import {
AbortController as NodeAbortController,
createRequestHandler as createRemixRequestHandler,
Headers as NodeHeaders,
Request as NodeRequest,
Expand All @@ -10,12 +17,6 @@ import type {
HandlerContext,
HandlerResponse,
} from "@netlify/functions";
import type {
AppLoadContext,
ServerBuild,
RequestInit as NodeRequestInit,
Response as NodeResponse,
} from "@remix-run/node";

import { isBinaryType } from "./binaryTypes";

Expand Down Expand Up @@ -67,12 +68,14 @@ export function createRemixRequest(event: HandlerEvent): NodeRequest {

// Note: No current way to abort these for Netlify, but our router expects
// requests to contain a signal so it can detect aborted requests
let controller = new AbortController();
let controller = new NodeAbortController();

let init: NodeRequestInit = {
method: event.httpMethod,
headers: createRemixHeaders(event.multiValueHeaders),
signal: controller.signal,
// Cast until reason/throwIfAborted added
// https://github.com/mysticatea/abort-controller/issues/36
signal: controller.signal as NodeRequestInit["signal"],
};

if (event.httpMethod !== "GET" && event.httpMethod !== "HEAD" && event.body) {
Expand Down
6 changes: 4 additions & 2 deletions packages/remix-vercel/server.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import type {
Response as NodeResponse,
} from "@remix-run/node";
import {
AbortController,
AbortController as NodeAbortController,
createRequestHandler as createRemixRequestHandler,
Headers as NodeHeaders,
Request as NodeRequest,
Expand Down Expand Up @@ -85,12 +85,14 @@ export function createRemixRequest(
let url = new URL(req.url!, `${protocol}://${host}`);

// Abort action/loaders once we can no longer write a response
let controller = new AbortController();
let controller = new NodeAbortController();
res.on("close", () => controller.abort());

let init: NodeRequestInit = {
method: req.method,
headers: createRemixHeaders(req.headers),
// Cast until reason/throwIfAborted added
// https://github.com/mysticatea/abort-controller/issues/36
signal: controller.signal as NodeRequestInit["signal"],
};

Expand Down