Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(other-api/serve): add preserve cache in development example #4066

Merged

Conversation

jmorel88
Copy link
Contributor

Update docs with an example workaround for preserving cache in development. Example from #1884.

@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2022

⚠️ No Changeset found

Latest commit: 3b7efc4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 25, 2022

Hi @jmorel88,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 25, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title update @remix-run/serve docs docs(other-api/serve): add preserve cache in development example Aug 25, 2022
docs/other-api/serve.md Outdated Show resolved Hide resolved
docs/other-api/serve.md Outdated Show resolved Hide resolved
jmorel88 and others added 2 commits August 25, 2022 13:19
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
Copy link
Collaborator

@machour machour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small update to respect the code style, otherwise looks great!

docs/other-api/serve.md Outdated Show resolved Hide resolved
docs/other-api/serve.md Outdated Show resolved Hide resolved
jmorel88 and others added 2 commits September 3, 2022 13:34
Co-authored-by: Mehdi Achour <machour@gmail.com>
Co-authored-by: Mehdi Achour <machour@gmail.com>
@machour machour assigned chaance and unassigned mcansh Sep 3, 2022
@chaance chaance merged commit dd0f018 into remix-run:main Sep 3, 2022
freeman pushed a commit to freeman/remix that referenced this pull request Sep 7, 2022
…ix-run#4066)

Co-authored-by: Mehdi Achour <machour@gmail.com>
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
Co-authored-by: Mehdi Achour <machour@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants