Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(templates/cloudflare-pages): add _routes.json #4050

Merged
merged 1 commit into from Aug 24, 2022

Conversation

jrf0110
Copy link
Contributor

@jrf0110 jrf0110 commented Aug 23, 2022

馃憢

John here from the Cloudflare Pages team.

_routes.json is a new optional file from Cloudflare Pages. It describes how Pages Functions are routed through the Cloudflare Workers runtime. Via inclusion and exclusion rules, we route traffic to your Pages Functions or to static assets.

As noted in the contributing doc, I've branched off of main instead of dev since this only changes a template.

@changeset-bot
Copy link

changeset-bot bot commented Aug 23, 2022

鈿狅笍 No Changeset found

Latest commit: 0f7eab6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 23, 2022

Hi @jrf0110,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

_routes.json is a new optional file from Cloudflare Pages. It describes how [Pages Functions](https://developers.cloudflare.com/pages/platform/functions/) are routed through the Cloudflare Workers runtime. Via inclusion and exclusion rules, we route traffic to your Pages Functions or to static assets.
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 23, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 馃コ

@MichaelDeBoey MichaelDeBoey changed the title chore(templates): Update CF Pages template to include new routes spec feat(templates/cloudflare-pages): add _routes.json Aug 24, 2022
@MichaelDeBoey MichaelDeBoey merged commit 2ab4e0b into remix-run:main Aug 24, 2022
kayac-chang pushed a commit to kayac-chang/remix that referenced this pull request Sep 3, 2022
freeman pushed a commit to freeman/remix that referenced this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants