Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(tutorial/jokes): fix typo #3962

Merged
merged 5 commits into from Aug 30, 2022
Merged

docs(tutorial/jokes): fix typo #3962

merged 5 commits into from Aug 30, 2022

Conversation

shairez
Copy link
Contributor

@shairez shairez commented Aug 8, 2022

Closes: #

  • Docs
  • Tests

The :jokeId and $jokeId convention is confusing.

The tutorial shows /jokes/:jokeId but then talks about $jokeId referring to what we just saw.
It looks like a typo

@changeset-bot
Copy link

changeset-bot bot commented Aug 8, 2022

⚠️ No Changeset found

Latest commit: 5821685

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 8, 2022

Hi @shairez,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@MichaelDeBoey MichaelDeBoey changed the title docs: fix a typo in jokeId param docs(tutorial/jokes): fix typo Aug 8, 2022
docs/tutorials/jokes.md Outdated Show resolved Hide resolved
docs/tutorials/jokes.md Outdated Show resolved Hide resolved
@MichaelDeBoey
Copy link
Member

@shairez Please sign the CLA in order to get this merged.

@MichaelDeBoey MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label Aug 8, 2022
to be able to merge the smallest of the PRs :)
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Aug 30, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

shairez and others added 3 commits August 30, 2022 00:54
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
@shairez
Copy link
Contributor Author

shairez commented Aug 30, 2022

@MichaelDeBoey took me a while, but now it's done :)

@machour machour merged commit 724340d into remix-run:main Aug 30, 2022
@machour
Copy link
Collaborator

machour commented Aug 30, 2022

Thank you @shairez !

@machour machour removed the needs-response We need a response from the original author about this issue/PR label Aug 30, 2022
kayac-chang pushed a commit to kayac-chang/remix that referenced this pull request Sep 3, 2022
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
freeman pushed a commit to freeman/remix that referenced this pull request Sep 7, 2022
Co-authored-by: Michaël De Boey <info@michaeldeboey.be>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants