Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples/blog-tutorial): revert update of @testing-library/react dependency #3924

Merged
merged 1 commit into from Aug 4, 2022

Conversation

MichaelDeBoey
Copy link
Member

This shouldn't have been done in #3917, as that example is still using React v17

@changeset-bot
Copy link

changeset-bot bot commented Aug 4, 2022

⚠️ No Changeset found

Latest commit: bc9bceb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey changed the title chore(examples/blog-tutorial): revert update of `@testing-library/rea… chore(examples/blog-tutorial): revert update of @testing-library/react dependency Aug 4, 2022
@kentcdodds kentcdodds merged commit 9e66a5c into remix-run:dev Aug 4, 2022
@kentcdodds
Copy link
Member

We need to get all the examples and things on React 18

@MichaelDeBoey MichaelDeBoey deleted the revert-example-changes branch August 5, 2022 10:45
@MichaelDeBoey
Copy link
Member Author

@kentcdodds On it 👍

mcansh pushed a commit that referenced this pull request Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants