Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remix-react): unblock hydration via async module scripts #3918

Merged
merged 3 commits into from Aug 12, 2022

Conversation

jacob-ebey
Copy link
Member

Closes: #

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Aug 3, 2022

🦋 Changeset detected

Latest commit: 4577943

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@remix-run/react Patch
create-remix Patch
remix Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/cloudflare Patch
@remix-run/node Patch
@remix-run/deno Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/vercel Patch
@remix-run/architect Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ryanflorence
Copy link
Member

Jacob and I chatted and decided to make it look like this:

<html>
  <link rel="modulepreload" href="deps" />
  <link rel="modulepreload" href="deps" />
  <link rel="modulepreload" href="deps" />
  <link rel="modulepreload" href="deps" />

  <link rel="modulepreload" href="entry" />
  <link rel="preload" as="script" href="manifest" />

  <script async type=module>
    import "./manifest";
    import route1 from "./route1";
    import route2 from "./route2";
    import(entry)
  </script>
</html>

@MichaelDeBoey MichaelDeBoey changed the title feat: unblock hydration via async module scripts feat(remix-react): unblock hydration via async module scripts Aug 8, 2022
@jacob-ebey jacob-ebey merged commit b526aee into dev Aug 12, 2022
@jacob-ebey jacob-ebey deleted the unblock-hydration branch August 12, 2022 17:33
@MichaelDeBoey MichaelDeBoey added the awaiting release This issue has been fixed and will be released soon label Aug 15, 2022
@MichaelDeBoey MichaelDeBoey removed the awaiting release This issue has been fixed and will be released soon label Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants