Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@remix-run/react): preserve null properties for useLoaderData and useActionData inference #3879

Merged
merged 2 commits into from Jul 30, 2022
Merged

fix(@remix-run/react): preserve null properties for useLoaderData and useActionData inference #3879

merged 2 commits into from Jul 30, 2022

Conversation

pcattori
Copy link
Contributor

Closes: #

  • Docs
  • Tests

Testing Strategy:

@changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2022 •
edited

🦋 Changeset detected

Latest commit: 170c40a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
remix Patch
@remix-run/react Patch
create-remix Patch
@remix-run/dev Patch
@remix-run/eslint-config Patch
@remix-run/serve Patch
@remix-run/server-runtime Patch
@remix-run/cloudflare Patch
@remix-run/node Patch
@remix-run/deno Patch
@remix-run/cloudflare-pages Patch
@remix-run/cloudflare-workers Patch
@remix-run/express Patch
@remix-run/netlify Patch
@remix-run/vercel Patch
@remix-run/architect Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pcattori pcattori changed the title Pedro/undefined optionals fix(@remix-run/react): preserve null properties for useLoaderData and useActionData inference Jul 29, 2022
@pcattori pcattori mentioned this pull request Jul 29, 2022
Closed
@kentcdodds
Copy link
Member

Is this intended to be a hotfix or should we merge this into dev?

@pcattori pcattori changed the base branch from main to dev July 30, 2022 00:08
@pcattori
Copy link
Contributor Author

pcattori commented Jul 30, 2022 •
edited

Is this intended to be a hotfix or should we merge this into dev?

Good eye! Intended for dev, just forgot to point my PR there. It should be pointing to dev now.

@pcattori pcattori mentioned this pull request Jul 30, 2022
Closed
kentcdodds
kentcdodds approved these changes Jul 30, 2022
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works great. Thank you!

@kentcdodds kentcdodds merged commit 2b73608 into dev Jul 30, 2022
@kentcdodds kentcdodds deleted the pedro/undefined-optionals branch July 30, 2022 14:39
@github-actions github-actions bot mentioned this pull request Jul 30, 2022
Merged
@mcansh mcansh mentioned this pull request Jan 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
CLA Signed feat:typescript renderer:react
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pcattori @kentcdodds @MichaelDeBoey