Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use ternaries rather than && in JSX #1948

Merged
merged 1 commit into from Feb 14, 2022
Merged

refactor: use ternaries rather than && in JSX #1948

merged 1 commit into from Feb 14, 2022

Conversation

MichaelDeBoey
Copy link
Member

Just like the last couple of times

CC/ @kentcdodds

kentcdodds
kentcdodds approved these changes Feb 14, 2022
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll probably fight this forever to be honest, but I'll go ahead and merge anyway 😆 thanks!

@kentcdodds kentcdodds merged commit 898379e into remix-run:main Feb 14, 2022
@MichaelDeBoey MichaelDeBoey deleted the use-ternaries-instead-of-and-and branch February 14, 2022 09:04
@MichaelDeBoey
Copy link
Member Author

Whenever we there's a PR for jsx-eslint/eslint-plugin-react#2073, we can add the rule and never do this manually again 😅🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
CLA Signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MichaelDeBoey @kentcdodds