Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(remix-react): add event type to useBeforeUnload #1723

Merged
merged 4 commits into from Oct 28, 2022

Conversation

Runner-dev
Copy link
Contributor

@Runner-dev Runner-dev commented Jan 30, 2022

Add event type to onBeforeUnload allowing it to be used in typescript code without errors

Fixes issue #1719

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 30, 2022

Hi @Runner-dev,

Welcome, and thank you for contributing to Remix!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@Runner-dev Runner-dev changed the title Add event type to useBeforeUnload (#1719) Add event type to useBeforeUnload Jan 30, 2022
@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jan 30, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@machour machour linked an issue Mar 17, 2022 that may be closed by this pull request
@sergiodxa
Copy link
Member

@mcansh
Copy link
Collaborator

mcansh commented Mar 18, 2022

@Runner-dev could you add yourself to main/contributors.yml ?

looks like they did 18548f7 - I'll check the cla bot

never mind, i think the dev merge removed it 🙈

@MichaelDeBoey MichaelDeBoey changed the title Add event type to useBeforeUnload fix(remix-react): add event type to useBeforeUnload Mar 27, 2022
@MichaelDeBoey
Copy link
Member

@Runner-dev Could you please rebase your branch onto dev?
That way your name will be added to contributors.yml again and we can merge this PR.

@MichaelDeBoey MichaelDeBoey added the needs-response We need a response from the original author about this issue/PR label Mar 27, 2022
@chaance chaance merged commit 5020fa4 into remix-run:dev Oct 28, 2022
@github-actions
Copy link
Contributor

🤖 Hello there,

We just published version v0.0.0-nightly-5020fa4-20221029 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

@MichaelDeBoey MichaelDeBoey removed the needs-response We need a response from the original author about this issue/PR label Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: useBeforeUnload TypeScript issue
6 participants