fix: useFormAction should not include pathless splat portion #9144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ee3ab78 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
force-pushed
the
brophdawg11/fix-splat-useFormAction
branch
from
0a0f647
to
b43374d
Compare
brophdawg11
commented
Aug 10, 2022
| @@ -1493,11 +1493,11 @@ function testDomRouter( | |||
| ); | |||
|
|
|||
| expect(container.querySelector("form")?.getAttribute("action")).toBe( | |||
| "/foo/bar?a=1#hash" | |||
| "/foo?a=1#hash" | |||
There was a problem hiding this comment.
This was the misunderstanding - splat portion should not be included here for now to match Link behavior
chaance
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to correct a small misunderstanding on #9060 after chatting through with Chance and Ryan a bit more.