Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix scroll position of History Object #9062

Merged
merged 1 commit into from Jul 15, 2022
Merged

Conversation

yuleicul
Copy link
Contributor

@yuleicul yuleicul commented Jul 15, 2022

Bug descriptions

image
When I click History Object in the nav bar, the scroll position is as the screenshot above.

What I expect

image
When I click History Object in the nav bar, the scroll position is on the title of History Object.

What did I do

I change the id of History in Chapter Definitions to history, which ensures that there is just one #history and one #history-object on the current page.

@changeset-bot
Copy link

changeset-bot bot commented Jul 15, 2022

⚠️ No Changeset found

Latest commit: 3781440

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@timdorr
Copy link
Member

timdorr commented Jul 15, 2022

Thanks!

@timdorr timdorr merged commit 912ba86 into remix-run:main Jul 15, 2022
@yuleicul yuleicul deleted the docs branch July 15, 2022 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants