Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint about "replace" in "useNavigate" documentation #8991

Merged
merged 3 commits into from Jun 18, 2022
Merged

Add hint about "replace" in "useNavigate" documentation #8991

merged 3 commits into from Jun 18, 2022

Conversation

Elanis
Copy link
Contributor

@Elanis Elanis commented Jun 17, 2022

When reading the v6 doc I noticed there were no mention of what "replace" is used for on the "useNavigate" page. This PR fixes this issue.

@changeset-bot
Copy link

changeset-bot bot commented Jun 17, 2022

⚠️ No Changeset found

Latest commit: f81f45a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 17, 2022

Hi @Elanis,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 17, 2022

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@timdorr
Copy link
Member

timdorr commented Jun 18, 2022

Thanks!

@timdorr timdorr merged commit 854f4a4 into remix-run:main Jun 18, 2022
@Elanis
Copy link
Contributor Author

Elanis commented Jun 18, 2022

No problem ;)

scarf005 added a commit to scarf005/react-router that referenced this pull request Apr 6, 2023
restored the line since despite remix-run#8991 got merged into main, 854f4a4 was nowhere to be seen in commit history.

Co-authored-by: Axel <Elanis@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants