Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tutorial): use "root" as root div id #8582

Merged
merged 2 commits into from Jan 16, 2022
Merged

fix(tutorial): use "root" as root div id #8582

merged 2 commits into from Jan 16, 2022

Commits on Jan 14, 2022

  1. fix(tutorial): use "root" as root div id 

    The documentation in /docs/getting-started uses "root" as the root element id, including in code snippets. So if a learner is following the tutorial documentation, they'll break their app when they copy-paste the tutorial snippets (which use "root") into the template (which was using "app").

Now the docs and the template both use "root".
    @ChristopherChudzicki
    ChristopherChudzicki committed Jan 14, 2022
    Copy the full SHA
    f45eda1 View commit details
    Browse the repository at this point in the history

  2. sign cla

    @ChristopherChudzicki
    ChristopherChudzicki committed Jan 14, 2022
    Copy the full SHA
    7445d69 View commit details
    Browse the repository at this point in the history