Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs:Add unstable_HistoryRouter to the api.md document #8476

Merged
merged 8 commits into from Feb 5, 2022

Conversation

hsbtr
Copy link
Contributor

@hsbtr hsbtr commented Dec 13, 2021

A great idea

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 13, 2021

Hi @hsbtr,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run.

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Dec 13, 2021

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@hornta
Copy link

hornta commented Feb 4, 2022

Why is this on hold? It's clearly a feature that needs to be documented even though it's marked as unstable.

@timdorr
Copy link
Member

timdorr commented Feb 5, 2022

Some of the grammar was kind of awkward (I don't believe English is @hsbtr's first language). I reworded it for clarity now.

Thanks!

formatted 783b3b5
@timdorr timdorr merged commit 1cab4cd into remix-run:main Feb 5, 2022
@hsbtr
Copy link
Contributor Author

hsbtr commented Feb 7, 2022

Some of the grammar was kind of awkward (I don't believe English is @hsbtr's first language). I reworded it for clarity now.

Thanks!

Your guess is correct, English is indeed not my first language, thank you very much for pointing out and correcting my grammatical mistakes

@timdorr
Copy link
Member

timdorr commented Feb 7, 2022

Thanks for getting things started in the first place!

@chris-muiru
Copy link

am facing this errors
export 'useHistory' (imported as 'useHistory') was not found in 'react-router-dom'
export 'Redirect' (imported as 'Redirect') was not found in 'react-router-dom'

@hsbtr
Copy link
Contributor Author

hsbtr commented Feb 19, 2022

am facing this errors export 'useHistory' (imported as 'useHistory') was not found in 'react-router-dom' export 'Redirect' (imported as 'Redirect') was not found in 'react-router-dom'

Two APIs have been removed in the V6 version, you can pay attention to useLoaction and Navigate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants