Use forwardRef on Link, NavLink #6914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanflorence
force-pushed
the
forwardRef
branch
from
1fdbdb8
to
349c068
Compare
|
u da man! |
ryanflorence
force-pushed
the
forwardRef
branch
from
349c068
to
97d49f1
Compare
|
@mjackson can I get a review here? thanks! |
|
I don't think this can be merged into |
|
Ah, alright, I've done tricks before, I'll do them again, thanks Paul. |
This allows components like @reach/menu-button to manage focus or do anything else they need to with the underlying DOM element. While `ref` is preferred, the `innerRef` prop will still work.
ryanflorence
force-pushed
the
forwardRef
branch
from
97d49f1
to
3d2f5b1
Compare
ryanflorence
commented
Sep 13, 2019
ryanflorence
commented
Sep 13, 2019
pshrmn
approved these changes
Sep 13, 2019
|
LGTM, thanks @ryanflorence! Maybe we can use a similar technique to fix #6056. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows components like @reach/menu-button to manage focus or do anything else they need to with the underlying DOM element.
This prefers the forwarded ref, but
innerRefwill still work too.Related: reach/reach-ui#54