Add support for prerendering #11539
Add support for prerendering #11539
Conversation
🦋 Changeset detectedLatest commit: fd6493a The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| setHeaders: function (res, path, stat) { | ||
| if (path.endsWith(".data")) { | ||
| res.set("Content-Type", "text/x-turbo"); | ||
| } else { | ||
| // Cache as an immutable asset for 1 year | ||
| // Do this here instead of via the immutable/maxAge headers so we can | ||
| // conditionally apply it to assets (which are hashed), and not | ||
| // pre-rendered .data files (not hashed) | ||
| res.set("Cache-Control", "public, max-age=31536000, immutable"); | ||
| } | ||
| }, |
There was a problem hiding this comment.
It feels potentially very bad to every put a 1 year immutable cache on a non-hashed .data URL, so this makes remix-serve by default not cache data files, and only apply the caching to other assets files.
| page, | ||
| app, | ||
| "#child-error", | ||
| "Unable to decode turbo-stream response" |
There was a problem hiding this comment.
See below, but we can't surface this underlying CDN error any longer with pre-rendering :/
| // Can't clone after consuming the body via turbo-stream so we can't | ||
| // include the body here. In an ideal world we'd look for a turbo-stream | ||
| // content type here, or even X-Remix-Response but then folks can't | ||
| // statically deploy their prerendered .data files to a CDN unless they can | ||
| // tell that CDN to add special headers to those certain files - which is a | ||
| // bit restrictive. | ||
| throw new Error("Unable to decode turbo-stream response"); | ||
| } |
There was a problem hiding this comment.
This is why we can't surface the res.text() of CDN errors
| export const isSpaMode = ${ | ||
| !ctx.reactRouterConfig.ssr && ctx.reactRouterConfig.prerender == null | ||
| }; |
There was a problem hiding this comment.
"SPA Mode" is specifically no SSR and only generating a root index.html - this isSpaMode flag is what tells the server.client not to SSR/hydrate beyond the root route.
| let { handler } = await getPrerenderBuildAndHandler( | ||
| viteConfig, | ||
| reactRouterConfig, | ||
| serverBuildDirectory | ||
| ); |
There was a problem hiding this comment.
SPA Mode is effectively untouched, just sharing some code for creating the handler with the prerender code paths
packages/remix-dev/vite/plugin.ts
Outdated
| if (hasLoaders) { | ||
| await prerenderData( | ||
| handler, | ||
| reactRouterConfig.basename, | ||
| path, | ||
| clientBuildDirectory, | ||
| viteConfig, | ||
| requestInit | ||
| ); | ||
| } |
There was a problem hiding this comment.
Prerender .data files for any routes with at least one loader
Add support for a
prerenderconfig that pre-renders HMTL and.datafiles for whatever URLs you specify. You can then deploy these files to a CDN, and load serve the HTML documents which hydrate into SPA's and load the.datafiles on client side navigations