Expose promises from underlying router operations for use in react 19 #11521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 81be2c2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brophdawg11
commented
May 6, 2024
| React.useEffect(() => navigate("/with space"), []); | ||
| React.useEffect(() => { | ||
| navigate("/with space"); | ||
| }, [navigate]); |
There was a problem hiding this comment.
Tests needed to be updated so they don't return promises from useEffect
brophdawg11
commented
May 6, 2024
| @@ -142,7 +142,6 @@ type SetupOpts = { | |||
| initialEntries?: InitialEntry[]; | |||
| initialIndex?: number; | |||
| hydrationData?: HydrationState; | |||
| future?: FutureConfig; | |||
There was a problem hiding this comment.
Must be a duplicate from a merge conflict - we want the partial version below
brophdawg11
commented
May 6, 2024
| @@ -1366,7 +1371,7 @@ export function createRouter(init: RouterInit): Router { | |||
| return; | |||
| } | |||
|
|
|||
| return await startNavigation(historyAction, nextLocation, { | |||
| await startNavigation(historyAction, nextLocation, { | |||
There was a problem hiding this comment.
Open question - what should happen on interrupted navigations? Right now the promise will resolve with undefined when it gets interrupted. I don't think rejecting makes sense since we wouldn't want any error boundaries to trigger...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.