Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapse Packages #11505

Merged
merged 25 commits into from Apr 30, 2024
Merged

Collapse Packages #11505

merged 25 commits into from Apr 30, 2024

Conversation

brophdawg11
Copy link
Contributor

  • Collapses @remix-run/router, react-router-dom, and @remix-run/testing into react-router
  • react-router-dom is left for backwards compatibility and re-exports everything from react-router
    • along with logging a warning to inform users to update their imports to be from react-router

Copy link

changeset-bot bot commented Apr 26, 2024

🦋 Changeset detected

Latest commit: f1233ec

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -234,91 +232,115 @@ export {
useRoutes,
};

function mapRouteProperties(route: RouteObject) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moves down into components.tsx

});
}
// Expose old @remix-run/router API
export type {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remix router API exported from react-router now - we have a subsequent task to trim this down to remove anything that's meant to be an RR implementation detail

return updates;
}
// Expose old RR DOM API
export type {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

react-router-dom API exported through react-router now

@brophdawg11 brophdawg11 merged commit 5ae9979 into v7 Apr 30, 2024
8 checks passed
@brophdawg11 brophdawg11 deleted the brophdawg11/collapse-packages branch April 30, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant