Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changesets Setup #11475

Draft
wants to merge 2 commits into
base: v7
Choose a base branch
from
Draft

Changesets Setup #11475

wants to merge 2 commits into from

Conversation

brophdawg11
Copy link
Contributor

Minor updates to do some local testing of the changesets flow. With these changes you can:

# Enter prerelease mode and commit changes
pnpm exec changeset pre enter pre
git add .
git commit -a -m "Enter prerelease mode"

# Run version command to bump to 7.0.0-pre.0 and add entries to CHANGELOG's
export GITHUB_TOKEN="....."
pnpm exec changeset version
git add .
git commit -m "Prerelease"

# Run a dry publish run to see what would be published to npm
pnpm -r publish --dry-run --publish-branch brophdawg11/changesets

Everything looks good to me in that flow, so with these changes I think we'll be in good shape when it comes time to do a prerelease

Copy link

changeset-bot bot commented Apr 18, 2024

⚠️ No Changeset found

Latest commit: d3ef3ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@@ -1,6 +1,6 @@
{
"name": "@react-router/dev",
"version": "2.9.0-pre.0",
"version": "6.22.3",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed these to be in the 6.x range so they'll bump to 7.x when changesets does a major bump

@@ -1,6 +1,6 @@
{
"name": "@remix-run/router",
"version": "1.15.3",
"version": "6.22.3",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going away eventually so can just make it 6.x for now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To keep things simple do we want to keep this version fixed with the other packages then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - I guess it could go into the changesets fixed config - but it’ll get deleted from there before we do any v7 pre-releases (along with native/compat/dom) I think so might not ever have a chance to do anything?

@@ -1,4 +1,6 @@
{
"name": "playground-compiler-express",
"version": "0.0.0",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changesets doesn't run if these don't have names/versions

@@ -24,7 +24,7 @@
"baseBranch": "dev",
"updateInternalDependencies": "patch",
"bumpVersionsWithWorkspaceProtocolOnly": true,
"ignore": ["integration", "integration-*"],
"ignore": ["integration", "integration-*", "playground-*"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants