New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changesets Setup #11475
base: v7
Are you sure you want to change the base?
Changesets Setup #11475
Conversation
|
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@react-router/dev", | |||
"version": "2.9.0-pre.0", | |||
"version": "6.22.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needed these to be in the 6.x range so they'll bump to 7.x when changesets does a major bump
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "@remix-run/router", | |||
"version": "1.15.3", | |||
"version": "6.22.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going away eventually so can just make it 6.x for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To keep things simple do we want to keep this version fixed with the other packages then?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah - I guess it could go into the changesets fixed
config - but it’ll get deleted from there before we do any v7 pre-releases (along with native/compat/dom) I think so might not ever have a chance to do anything?
@@ -1,4 +1,6 @@ | |||
{ | |||
"name": "playground-compiler-express", | |||
"version": "0.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changesets doesn't run if these don't have names/versions
@@ -24,7 +24,7 @@ | |||
"baseBranch": "dev", | |||
"updateInternalDependencies": "patch", | |||
"bumpVersionsWithWorkspaceProtocolOnly": true, | |||
"ignore": ["integration", "integration-*"], | |||
"ignore": ["integration", "integration-*", "playground-*"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this.
Minor updates to do some local testing of the changesets flow. With these changes you can:
Everything looks good to me in that flow, so with these changes I think we'll be in good shape when it comes time to do a prerelease