HashRouter hashType option. Compatibility with v4/v5 #11310
Conversation
|
Hi @Whaileee, Welcome, and thank you for contributing to React Router! Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once. You may review the CLA and sign it by adding your name to contributors.yml. Once the CLA is signed, the If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at hello@remix.run. Thanks! - The Remix team |
🦋 Changeset detectedLatest commit: f93310c The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
|
Check for bundle size already fixed. I'm still having some issues with this failing test. This test seems to pass for node >= 18. Not sure why v16 is not working. Also I noticed that when 2 of 3 of these test functions are present it passes, no matter which. Also for some reason, the order seems to matter. I would really appreciate any suggestion. |
|
seems like --runInBand solves this problem, but I don't think that's the preferred solution |
Whaileee
force-pushed
the
dev
branch
2 times, most recently
from
df6caa6
to
8824908
Compare
Whaileee
force-pushed
the
dev
branch
4 times, most recently
from
1994c9a
to
8457a4d
Compare
|
The change is done imo, can I ask for a review and workflow approval? |
Whaileee
force-pushed
the
dev
branch
4 times, most recently
from
92e46c0
to
f1a9dd4
Compare
|
Is it good to merge? |
|
Can I ask for workflow approval? |
During migration from v4/v5 to v6 I've found that hashType is not implemented in newer version. This is an issue since there is a whole instruction on migration. I cannot change the type of encoding in project that this is applicable to.
I've raised an issue quite some time ago, but misspelled the prop name, hence the issue was closed.
Looking forward to resolve any of my errors and I'd love to see this merged/released asap.
Thanks in advance
Issue
v5 related docs