Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mantine): fix FOUC and handle error styles #309

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

markdalgleish
Copy link
Member

@markdalgleish markdalgleish commented Aug 8, 2023

This fixes a couple of issues with the Mantine example:

Copy link
Member

@MichaelDeBoey MichaelDeBoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if e should merge all of these changes tbh, as we try to have our examples as small as possible and this seems to add a lot of unnecessary boilerplate to the example

I think the goal here is: get Mantine working + have 1 page of styling
WDYT?

@markdalgleish
Copy link
Member Author

I was matching a similar workaround in the Emotion example.

I definitely understand the concern, but I also feel like this repo doubles as a set of manual tests for the different integrations. In this case we're working around a particular issue quite heavily and I think it's helpful that the example allows us to exercise that code path.

@markdalgleish markdalgleish merged commit 6882816 into main Aug 10, 2023
1 check passed
@markdalgleish markdalgleish deleted the markdalgleish/fix-mantine-fouc-and-error-styles branch August 10, 2023 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

None yet

2 participants