Fix type errors

[remcohaszing]

Initial checklist

• I read the support docs
• I read the contributing guide
• I agree to follow the code of conduct
• I searched issues and couldn’t find anything (or linked relevant results below)
• If applicable, I’ve added docs and tests

Description of changes

Since typical usage of unified-lint-rule involves inferring the type based on a function call, the inferred type should be public. If private types are used, TypeScript will generate types for dependant packages that use relative paths.

To solve this, public types in unified-lint-rule were moved from lib/index.js to index.js. lintRule only uses these public types.

The severity can be set as a boolean. To support this, the Label type now accepts a boolean type.

Two tests explicitly test bad input. These are annotated with a @ts-expect-error comment.

[wooorm]

Since typical usage of unified-lint-rule involves inferring the type based on a function call, the inferred type should be public. If private types are used, TypeScript will generate types for dependant packages that use relative paths.

Why not make more types public? That would be a smaller PR, right?

The severity can be set as a boolean. To support this, the Label type now accepts a boolean type.

Can you do this in a separate PR? That way, we can focus on how to solve completely broken types here.

---

Also, you can use import('package-name') instead of import('../index.js'), with export maps.
I prefer that, as it shows that something is from the public API instead of from a private internal lib file.

[remcohaszing]

Why not make more types public? That would be a smaller PR, right?

Which type? SeverityTuple is only used internally.

Can you do this in a separate PR? That way, we can focus on how to solve completely broken types here.

That would cause a type error in the tests.

Also, you can use import('package-name') instead of import('../index.js'), with export maps. I prefer that, as it shows that something is from the public API instead of from a private internal lib file.

Nice, I like it.

---

Note that TypeScript 5.5’s @import annotation will allow us to add the type imports on top instead of using import('module').Type type annotations.