Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Optional catch binding is a new feature introduced in ECMAScript… #737

Closed
wants to merge 1 commit into from

Conversation

QiRaining
Copy link

@QiRaining QiRaining commented Apr 6, 2023

… 2019 (ES10), and older versions of browsers might not support it.

image

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

TODO

… 2019 (ES10), and older versions of browsers might not support it.
@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Apr 6, 2023
@github-actions

This comment has been minimized.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9034dbd) 100.00% compared to head (6eaccb3) 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #737   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          759       759           
=========================================
  Hits           759       759           
Impacted Files Coverage Δ
lib/ast-to-react.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@remcohaszing
Copy link
Member

This is a duplicate of #697. Optional catch binding is supported as per the Compatibility section in the readme. You can use Babel to transpile dependencies to support older engines.

@github-actions

This comment has been minimized.

@remcohaszing remcohaszing added the 👯 no/duplicate Déjà vu label Apr 6, 2023
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Hi! Thanks for taking the time to contribute!

Because we treat pull requests as our backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn’t an exact duplicate but is closely related.

Thanks,
— bb

@github-actions
Copy link

github-actions bot commented Apr 6, 2023

Hi team! It seems this post is a duplicate, but hasn’t been marked as such. Please post a comment w/ Duplicate of #123(no final .) to do so. See GH docs for more info.

Thanks,
— bb

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 👋 phase/new Post is being triaged automatically labels Apr 6, 2023
@remcohaszing
Copy link
Member

Duplicate of #697

@remcohaszing remcohaszing marked this as a duplicate of #697 Apr 6, 2023
@QiRaining
Copy link
Author

This is a duplicate of #697. Optional catch binding is supported as per the Compatibility section in the readme. You can use Babel to transpile dependencies to support older engines.

So this tool suggests using Babel or older engines, what was the original intention behind creating this tool?
Funny suggestions

@ChristianMurphy
Copy link
Member

ChristianMurphy commented Apr 6, 2023

This library, react-markdown converts markdown into react.
And targets modern evergreen browsers by default.
It can also be used with legacy browsers, using babel to transpired and polyfill.

The modern browser first approach is done because we don't want to force millions of people to download legacy syntax and polyfills they don't need.

In the cases legacy support is needed, Babel or SWC can quickly and efficiently add only the syntax and polyfills that you and your specific browser matrix need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👯 no/duplicate Déjà vu 👎 phase/no Post cannot or will not be acted on
Development

Successfully merging this pull request may close these issues.

None yet

4 participants