Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure backwards compatibility for html-dom-parser's ES Module #446

Merged
merged 2 commits into from
Feb 6, 2022

Conversation

remarkablemark
Copy link
Owner

Fixes #445

What is the motivation for this pull request?

fix: support backwards compatibility for html-dom-parser's ES Module

Regression was caused in 1.4.7. Related to remarkablemark/html-dom-parser#202

What is the current behavior?

next@10 throws an error:

TypeError: htmlToDOM is not a function

Note: next@11 and 12 did not have this error

What is the new behavior?

No error in next@10

Checklist:

@remarkablemark remarkablemark added the bug Something isn't working label Feb 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 6, 2022

Codecov Report

Merging #446 (5f724cc) into master (03747b8) will increase coverage by 25.73%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           master      #446       +/-   ##
============================================
+ Coverage   74.26%   100.00%   +25.73%     
============================================
  Files           8         8               
  Lines         136       167       +31     
  Branches       35        57       +22     
============================================
+ Hits          101       167       +66     
+ Partials       35         0       -35     
Impacted Files Coverage Δ
index.js 100.00% <100.00%> (+18.75%) ⬆️
lib/utilities.js 100.00% <0.00%> (+25.00%) ⬆️
lib/attributes-to-props.js 100.00% <0.00%> (+25.80%) ⬆️
lib/dom-to-react.js 100.00% <0.00%> (+30.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03747b8...5f724cc. Read the comment docs.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/html-react-parser.min.js 9.49 KB (+0.35% 🔺) 190 ms (+0.35% 🔺) 90 ms (+21.16% 🔺) 280 ms

@remarkablemark remarkablemark merged commit 1daa39f into master Feb 6, 2022
@remarkablemark remarkablemark deleted the fix/html-dom-parser branch February 6, 2022 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError: htmlToDOM is not a function
2 participants