fix: Fixes exports to correctly export test utils #921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change slightly adjusts the exports in this repo's package.json in order to expose the required test utilities to consumers. While it works to provide the alias within release-it@529bc1f, it's slightly confusing to consumers who expect the export to map to a real path on disc. Relates to release-it#920 and tweaks release-it@529bc1f to use correct path.
|
cc @webpro - happy to discuss! |
|
To be very clear, if we use the following path: import { factory, runTasks } from 'release-it/test/util.js';This will work fine for ESM consumers since that path is aliased via Sorry if I'm restating the obvious :) |
|
@webpro just pinging on this again. Let me know if there's anything I can do to help! |
|
Alright, let's play it safe :) Thanks @scalvert! |
This was referenced Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change slightly adjusts the exports in this repo's package.json in order to expose the required test utilities to consumers.
While the alias provided in 529bc1f technically works for ESM consumers, it won't work for CJS consumers as that path isn't a real path on disc.
Relates to #920 and tweaks 529bc1f to use correct path.