Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility with release-it v15 #208

Merged
merged 7 commits into from Jul 19, 2022
Merged

Fix compatibility with release-it v15 #208

merged 7 commits into from Jul 19, 2022

Conversation

bertdeblock
Copy link
Contributor

@bertdeblock bertdeblock commented Jun 24, 2022

This will probably fail on the Node v12 scenario.

Closes #203.

.eslintrc.cjs Show resolved Hide resolved
index.js Show resolved Hide resolved
@RobbieTheWagner
Copy link

@bertdeblock have you tried this out and it works? Might use your branch here until this is merged.

@bertdeblock
Copy link
Contributor Author

@rwwagner90 I used the --dry-run flag to manually test these changes, but I didn't do an actual release.
Everything went smooth when performing a dry run, so I don't expect any hiccups when doing a real release.
All tests were passing as well locally. If you do use this branch, feel free to ping me if you run into any issues.

Copy link
Collaborator

@scalvert scalvert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also add version 15 to the ci.yml's release-it version matrix.

test.js Show resolved Hide resolved
@scalvert scalvert merged commit 9088903 into release-it-plugins:master Jul 19, 2022
@bertdeblock
Copy link
Contributor Author

Thanks for finishing this @scalvert! I was on vacation.

@scalvert
Copy link
Collaborator

scalvert commented Aug 6, 2022

My pleasure, @bertdeblock! Hope your vacation was good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with release-it v15
3 participants