Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to support release-it@15 (ESM) #73

Merged
merged 8 commits into from
Jul 18, 2022

Conversation

refi93
Copy link
Contributor

@refi93 refi93 commented Jul 7, 2022

Motivation: refactor the package to work with release-it v15 which transitioned to ESM modules

Testing: run unit tests with yarn test

closes #68

jest.config.js Show resolved Hide resolved
index.js Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@alvarlagerlof
Copy link

I tried copying the files in this pull request into my monorepo and I can confirm that it works for me. Successfully published.

@alvarlagerlof
Copy link

It looks like nothing has been committed to this repo since Oct 2021, the latest release in Apr that year. The author is not active. I think we should consider a fork. Are you interested in collaborating on one? @refi93

@refi93
Copy link
Contributor Author

refi93 commented Jul 11, 2022

It looks like nothing has been committed to this repo since Oct 2021, the latest release in Apr that year. The author is not active. I think we should consider a fork. Are you interested in collaborating on one? @refi93

I see, I'm not sure if I would have the time for maintaining the fork long-term either, but of course, whoever can, feel free to pick these changes up and make it 👍

@scalvert
Copy link
Collaborator

scalvert commented Jul 13, 2022

@rwjblue has been out on holiday. I'm happy to take a look at this too. We don't need a fork.

I just finished a large ESM refactor myself, so hopefully can provide assistance.

@scalvert
Copy link
Collaborator

Since we're going to be releasing this as a breaking change, and the ESM conversion essentially opts us into ESM-land, it strikes me that we should remove release-it < 15 from the test matrix, since there's no expectation that we can use this plugin within release-it's versions that are CJS-based.

@scalvert scalvert requested a review from rwjblue July 13, 2022 18:27
__tests__/plugin-test.js Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@scalvert
Copy link
Collaborator

It looks like we'll need to remove the required checks, but I don't have access to this repo's settings since it's under @rwjblue's personal GH user. I'll try to ping him to address this once he's back.

@scalvert scalvert merged commit 4e0d5c2 into release-it-plugins:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support release-it v15
3 participants