Retry brew requests [CLOUDDST-22680] #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilyzheng
requested review from
rohanpm,
rbikar and
chandwanitulsi
as code owners
rohanpm
requested changes
May 13, 2024
| @@ -134,6 +134,7 @@ def __init__( | |||
| timeout=60 * 30, | |||
| cache=None, | |||
| executor=None, | |||
| koji_opts=None, | |||
There was a problem hiding this comment.
Can we please not add this to the public API? I think it would be fine to simply hardcode that {"anon_retry": True} is always used, and not allow the caller to set the options.
Nothing in the API/docs currently promises that KojiSource works by using a koji.ClientSession, it's only an implementation detail. Adding this API is exposing that implementation detail and making it potentially harder to change in the future.
non-logged-in brew requests are not retried by default. Enable the retry to reduce push failures caused by brew connection issues.
emilyzheng
force-pushed
the
retry-brew-request
branch
from
f9e468c
to
4703d01
Compare
rohanpm
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
non-logged-in brew requests are not retried by default. Enable the retry to reduce push failures caused by brew connection issues.