Load product metadata from ProductID certificates [RHELDST-24276] #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalHaluza
requested review from
rohanpm,
rbikar and
chandwanitulsi
as code owners
MichalHaluza
commented
May 7, 2024
|
@rohanpm, @rbikar, @amcmahon-rh please review |
rohanpm
reviewed
May 7, 2024
rohanpm
reviewed
May 7, 2024
MichalHaluza
force-pushed
the
load_productid_products
branch
2 times, most recently
from
b52cf09
to
a1dd6bb
Compare
python-rhsm cannot be installed with GCC 14. Given that project has been deprecated for years, it's unlikely the actual underlying issue will be resolved. There are several projects in the distribution realm that used python-rhsm to read ProductID certificates and pull product metadata from them. After some internal discussion, pushsource seems to be an acceptable place where to put the replacement code which can be used instead of python-rhsm. This commit adds logic for reading metadata from Red Hat ProductID certificate files leveraging `cryptography` and `pyasn1` modules. It also slightly adjusts `conv.sloppylist()` so the individual string elements are stripped of leading and trailing whitespaces after splitting.
MichalHaluza
force-pushed
the
load_productid_products
branch
from
62d2035
to
7454c10
Compare
for more information, see https://pre-commit.ci
rbikar
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
python-rhsm cannot be installed with GCC 14. Given that project has been deprecated for years, it's unlikely the actual underlying issue will be resolved. There are several projects in the distribution realm that used python-rhsm to read ProductID certificates and pull product metadata from them. After some internal discussion, pushsource seems to be an acceptable place where to put the replacement code which can be used instead of python-rhsm.
This commit adds logic for reading metadata from Red Hat ProductID certificate files leveraging
cryptographyandpyasn1modules.It also slightly adjusts
conv.sloppylist()so the individual string elements are stripped of leading and trailing whitespaces after splitting.