Fix test failures with pytest 5 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str() behavior on pytest ExceptionInfo objects was changed in pytest 5.0.0: pytest-dev/pytest#5412 This caused various tests to fail, as it was assumed that str() on those objects would include exception messages. Update the tests to check the exceptions instead, rather than the ExceptionInfo wrappers.
alexandrevicenzi
approved these changes
Jul 2, 2019
rbikar
approved these changes
Jul 2, 2019
rajulkumar
approved these changes
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
str() behavior on pytest ExceptionInfo objects was changed in
pytest 5.0.0: pytest-dev/pytest#5412
This caused various tests to fail, as it was assumed that str()
on those objects would include exception messages. Update the
tests to check the exceptions instead, rather than the
ExceptionInfo wrappers.