Revert "Remove workarounds for old version of attrs library" #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalHaluza
requested review from
rohanpm,
rajulkumar and
rbikar
as code owners
This reverts commit 73e2568. The workarounds are still needed on RHEL 8 where the python 3.6 libraries are installed from RPMs as RHEL 8 ships attrs 17.4
MichalHaluza
force-pushed
the
revert_attr_workarounds
branch
from
402d4fc
to
56e0603
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #203 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 47 47
Lines 3153 3153
=========================================
Hits 3153 3153
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
I'm not addressing the bandit complaints about mocked requests timeout, as the bug which it is hitting, covered under PyCQA/bandit#996, was fixed earlier today and the fix will presumably get to the next bandit release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 73e2568.
The workarounds are still needed on RHEL 8 where the python 3.6 libraries are installed from RPMs as RHEL 8 ships attrs 17.4