Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Bump idna from 2.9 to 3.1" #150

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Revert "Bump idna from 2.9 to 3.1" #150

merged 1 commit into from
Mar 16, 2021

Conversation

negillett
Copy link
Member

Reverts #143

The requests package requires idna<3.

@negillett negillett merged commit d968bfa into master Mar 16, 2021
@negillett negillett deleted the revert-143-dependabot/pip/idna-3.1 branch March 16, 2021 15:42
@rohanpm
Copy link
Member

rohanpm commented Mar 16, 2021

I wonder if migrating this repo to use pip-compile properly (separate .in and .txt files) would have avoided this.

@negillett
Copy link
Member Author

I wonder if migrating this repo to use pip-compile properly (separate .in and .txt files) would have avoided this.

Yeah, I think so. Would probably have avoided #148 and #149 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crungehottman crungehottman crungehottman approved these changes

@rohanpm rohanpm Awaiting requested review from rohanpm rohanpm is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@negillett @rohanpm @crungehottman