New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow providing a list of characters to escape in PR titles #611
Merged
Merged
Changes from 15 commits
Commits
Show all changes
47 commits
Select commit
Hold shift + click to select a range
f17c5c5
Update schema.js
Happypig375 8faac16
Update default-config.js
Happypig375 dd8e1a0
Update template.js
Happypig375 1b14e17
Update template.js
Happypig375 ec0dcc6
Update releases.js
Happypig375 b14560f
Update README.md
Happypig375 ff7f545
Update schema.test.js
Happypig375 3e23e99
Format tables correctly
Happypig375 9aebd72
Update schema.json
Happypig375 124721e
Update schema.js
Happypig375 54ffe45
Revert template.js
Happypig375 00d48d5
Update releases.js
Happypig375 ba486c5
Update schema.json
Happypig375 6c73b59
Create config-with-change-title-escapes.yml
Happypig375 67a3f3d
Create config-with-change-title-escapes-backticks.yml
Happypig375 f1e7147
Update config-with-change-title-escapes.yml
Happypig375 5a3ddc6
Update config-with-change-title-escapes-backticks.yml
Happypig375 10448f0
Update README.md
Happypig375 bacd06b
Update README.md
Happypig375 42eec9b
Update releases.js
Happypig375 97f257f
Update README.md
Happypig375 4a9da5e
Update releases.js
Happypig375 84cca5e
Update README.md
Happypig375 aceaae1
Update README.md
Happypig375 9e5ee68
Update releases.js
Happypig375 c622189
Delete config-with-change-title-escapes.yml
Happypig375 48c5345
Delete config-with-change-title-escapes-backticks.yml
Happypig375 2bdeb98
Update releases.js
Happypig375 2549de2
Create releases.test.js
Happypig375 1fc086f
Update releases.test.js
Happypig375 03836a7
Update releases.test.js
Happypig375 87c53ef
Update releases.test.js
Happypig375 5275a8e
Update releases.js
Happypig375 d2a2e9c
Update releases.test.js
Happypig375 d244358
Update releases.test.js
Happypig375 27cd024
Update releases.test.js
Happypig375 42869fe
Update README.md
Happypig375 1580564
Update releases.test.js
Happypig375 7302f99
Update releases.js
Happypig375 f424208
Update releases.test.js
Happypig375 13351ed
Update releases.test.js
Happypig375 0ace598
Update releases.test.js
Happypig375 7c50b8a
Update releases.test.js
Happypig375 36330e9
Update releases.test.js
Happypig375 fac2fe3
Update releases.test.js
Happypig375 05cc4ce
`yarn jest --updateSnapshot`
jetersen c5cec30
`yarn lint --fix`
jetersen File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 10 additions & 0 deletions
10
test/fixtures/config/config-with-change-title-escapes-backticks.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
template: | | ||
# What's Changed | ||
$CHANGES | ||
categories: | ||
- label: feature | ||
title: 🚀 Features | ||
- label: fix | ||
title: 🐛 Bug Fixes | ||
|
||
change-title-escapes: '\<*_`' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
template: | | ||
# What's Changed | ||
$CHANGES | ||
categories: | ||
- label: feature | ||
title: 🚀 Features | ||
- label: fix | ||
title: 🐛 Bug Fixes | ||
|
||
change-title-escapes: '\<*_' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about escaping
@
There are two options according to github/markup#1168
One using zero-width space
or html comment<!-- -->
. I think the html comment is better as it is easier to "recreate" not everybody knows how to type a zero-width space.@jetersen
@jetersen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the zero-width space better as it doesn't clutter reading as much. We are auto-generating these lines anyways.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if user accidentally deletes the line and does not know how to type a zero-width space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jetersen @ jetersen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops it's a nbsp
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jetersen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe using comments is the way to go then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can also do this:
@​jetersen
@jetersen@ jetersen
@ jetersen
is not a good optionThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<!---->
@jetersen⁠
@jetersen
@jetersenComments seem to be the most obvious and short option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same trick can be used for #s.