New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a collapse-after
option for categories
#1095
Merged
Merged
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
6186a6e
Add category.collapse option
robbinjanssen 00416c5
Update build files
robbinjanssen 040715f
Replace map with for loops
robbinjanssen c1fffb7
Add test
robbinjanssen cd3fbb3
Fix typo
robbinjanssen 24c25bf
Remove debug
robbinjanssen eefb21d
Add extra test
robbinjanssen 80c188a
Use yarn
robbinjanssen f66f6e5
Update lib/releases.js
robbinjanssen b81beb0
Rename collapse to collapse-after
robbinjanssen 2752b93
Merge branch 'master' of github.com:exonet/release-drafter
robbinjanssen e45320a
Use default(0)
robbinjanssen eb9cfe3
Use strict comparison
robbinjanssen 41b8bf1
Define PR title once
robbinjanssen File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
18 changes: 18 additions & 0 deletions
18
test/fixtures/config/config-with-categories-with-collapse.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
template: | | ||
# What's Changed | ||
|
||
$CHANGES | ||
|
||
categories: | ||
- title: 🚀 All the things! | ||
collapse: true | ||
labels: | ||
- feature | ||
- enhancement | ||
- fix | ||
- bugfix | ||
- bug | ||
- sentry | ||
- skip-changelog | ||
- title: 👻 Maintenance | ||
label: chore |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you think this needs to be configurable, feel free to add it :)
Please follow the current config naming with
word-another-word
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could, but I have no idea what to name it 🙈 Any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
collapse-at
is fine it will go together withcollapse
. The readme would have to document whether it is greater than or less than that is used.The default may be greater than 3?
Potentially could move the condition to outside the if statement.
So the if statement might say
if (shouldCollapse)
orif (shouldNotCollapse)