Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update target_commitish when updating a release #1052

Merged
merged 1 commit into from Feb 3, 2022
Merged

Update target_commitish when updating a release #1052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 7 additions & 0 deletions dist/index.js
View file
Open in desktop
Expand Up @@ -129388,6 +129388,7 @@ const updateRelease = ({ context, draftRelease, releaseInfo }) => {
const updateReleaseParameters = updateDraftReleaseParameters({
name: releaseInfo.name || draftRelease.name,
tag_name: releaseInfo.tag || draftRelease.tag_name,
target_commitish: releaseInfo.commitish,
})

return context.octokit.repos.updateRelease(
Expand All @@ -129412,6 +129413,12 @@ function updateDraftReleaseParameters(parameters) {
delete updateReleaseParameters.tag_name
}

// Keep existing `target_commitish` if not overriden
// (sending `null` resets it to the default branch)
if (!updateReleaseParameters.target_commitish) {
delete updateReleaseParameters.target_commitish
}

return updateReleaseParameters
}

Expand Down
7 changes: 7 additions & 0 deletions lib/releases.js
View file
Open in desktop
Expand Up @@ -350,6 +350,7 @@ const updateRelease = ({ context, draftRelease, releaseInfo }) => {
const updateReleaseParameters = updateDraftReleaseParameters({
name: releaseInfo.name || draftRelease.name,
tag_name: releaseInfo.tag || draftRelease.tag_name,
target_commitish: releaseInfo.commitish,
})

return context.octokit.repos.updateRelease(
Expand All @@ -374,6 +375,12 @@ function updateDraftReleaseParameters(parameters) {
delete updateReleaseParameters.tag_name
}

// Keep existing `target_commitish` if not overriden
// (sending `null` resets it to the default branch)
if (!updateReleaseParameters.target_commitish) {
delete updateReleaseParameters.target_commitish
}

return updateReleaseParameters
}

Expand Down