Add support to ignore pre-releases #1039
Conversation
|
@chrgernoe could you try and use |
|
I think you would need to add an test inside |
lib/releases.js
Outdated
| if (preRelease) { | ||
| log({ context, message: `Pre-release: ${preRelease.tag_name}` }) | ||
| } else { | ||
| log({ context, message: `No pre-release found` }) | ||
| } |
There was a problem hiding this comment.
This should not log if use-latest-public is true?
Yes, I already did this but didn't checked it in since it was just a draft. I will do this as soon the PR is ready. |
OK. Thanks for the hint. I will try to implement this and also extend the doc. |
chrgernoe
force-pushed
the
feature/add-support-to-ignore-pre-release
branch
from
d4c4791
to
90b0567
Compare
|
@jetersen What is the best way to generate a new GraphQL file for the following sequence, which I need for testing the new feature?
Currently there is only a GraphQL file for |
|
I someone will have time to revive this because that is currently an annoying problem with release drafter as every time we decide to create a pre-release we endup with incomplete release notes for the follow-up release, requiring us to do a lot of copy/paste to restore the full changelog. As stated in the title, any pre-release should not be counted when building the changelog. |
|
I know @blast-hardcheese and I had a discussion for rendering everything for a prerelease since the last actual release. Right now my priority is to finish v6 and than I can more easily take on new features and PRs. |
|
@jetersen: The test is still open because of the question I asked above but unfortunately received no answer. |
|
Should be able to look at existing tests and copy one of the fixtures and add a prerelease. One of the reasons to no answer is driving pull request over the finish line requires a village 😅 |
Fixes #579.
I need this feature for another project and therefore implemented the solution as proposed in the issue. Because this is my first time I contribute to the project and I'm new to JavaScript, I need a bit guidance. I also would like to implement a test but I'm a bit lost what the best strategy is and how this framework works.