Allow adding the URL of the PR to the release notes #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetersen
approved these changes
Jul 1, 2020
lib/commits.js
Outdated
| @@ -35,6 +35,7 @@ module.exports.findCommitsWithAssociatedPullRequestsQuery = /* GraphQL */ ` | |||
| nodes { | |||
| title | |||
| number | |||
| url | |||
There was a problem hiding this comment.
could we do the same include trick as we did for body? Again to avoid pulling extra data that is not needed.
|
@b00men marvelous, thanks for your contribution! |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are actively uses a repo's release notes in scope of other repos.
This makes a github PR's short link (
#NUMBER) lead to a wrong place.So I would like to have an option to use an issue's complete URL instead of hardcoded replacements.