Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bot users don’t render quite right #60

Open
ticky opened this issue Aug 31, 2018 · 3 comments · May be fixed by #1376
Open

Bot users don’t render quite right #60

ticky opened this issue Aug 31, 2018 · 3 comments · May be fixed by #1376

Comments

@ticky
Copy link
Contributor

ticky commented Aug 31, 2018

It seems that bot users are inlined as usual, and count as contributors, which results in a bit of unusual rendering:

  • 7: Update dependency emoji-regex to v7.0.1 by @renovate[bot]

Thanks to @renovate-bot, @renovate[bot] and @ticky!
@toolmantim
Copy link
Collaborator

Yeah, that seems to be a general problem across GitHub right now. I was assuming GitHub would update their Markdown renderer to point them to the app page for the bot user, at some point. But we can do better in the meantime! Any suggestions?

For a start, we should filter bots out of $CONTRIBUTORS

@ticky
Copy link
Contributor Author

ticky commented Aug 31, 2018

Yeah, I’d suggest filtering them from contributors.

As far as for people concatenating it with an @, I’d suggest making the @ part of the variable, but in the interests of backward-compatibility, maybe it should prefix bots with a zero-width joiner? e.g. @‍renovate[bot]

@jamietanna jamietanna linked a pull request Jan 3, 2024 that will close this issue
Open
jamietanna added a commit to jamietanna/release-drafter that referenced this issue Jan 3, 2024
@jamietanna
Fix: Correctly mention bot accounts in release notes
8b04f12 
As noted in release-drafter#60, bot accounts are currently being mis-mentioned, where
instead of linking through to `dependabot[bot]` it'll tag a user
`@dependabot` which isn't the same, and can result in unwanted
notifications.

To address this, we can retrieve the type of user that has authored a
Pull Request, looking at the `__typename` to determine if it's a `Bot`
or a `User` account, and provide a Markdown link to the Bot account's
app page.

Unfortunately this may result in a name such as:

    @[dependabot[bot]](https://github.com/apps/dependabot)

But this is a better result than tagging the wrong account.

Closes release-drafter#60.
@jamietanna
Copy link

I've taken a stab at this with #1376 - happy to add in the zero-width joiner too / instead of Markdown linking to the app page?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Correctly mention bot accounts in release notes jamietanna/release-drafter
3 participants
@toolmantim @ticky @jamietanna