Update target_commitish when updating a release (#1052)

release-drafter · Feb 3, 2022 · c26ae71 · c26ae71
1 parent a8445e8
commit c26ae71
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/dist/index.js b/dist/index.js
@@ -129388,6 +129388,7 @@ const updateRelease = ({ context, draftRelease, releaseInfo }) => {
   const updateReleaseParameters = updateDraftReleaseParameters({
     name: releaseInfo.name || draftRelease.name,
     tag_name: releaseInfo.tag || draftRelease.tag_name,
+    target_commitish: releaseInfo.commitish,
   })
 
   return context.octokit.repos.updateRelease(
@@ -129412,6 +129413,12 @@ function updateDraftReleaseParameters(parameters) {
     delete updateReleaseParameters.tag_name
   }
 
+  // Keep existing `target_commitish` if not overriden
+  // (sending `null` resets it to the default branch)
+  if (!updateReleaseParameters.target_commitish) {
+    delete updateReleaseParameters.target_commitish
+  }
+
   return updateReleaseParameters
 }
 

diff --git a/lib/releases.js b/lib/releases.js
@@ -350,6 +350,7 @@ const updateRelease = ({ context, draftRelease, releaseInfo }) => {
   const updateReleaseParameters = updateDraftReleaseParameters({
     name: releaseInfo.name || draftRelease.name,
     tag_name: releaseInfo.tag || draftRelease.tag_name,
+    target_commitish: releaseInfo.commitish,
   })
 
   return context.octokit.repos.updateRelease(
@@ -374,6 +375,12 @@ function updateDraftReleaseParameters(parameters) {
     delete updateReleaseParameters.tag_name
   }
 
+  // Keep existing `target_commitish` if not overriden
+  // (sending `null` resets it to the default branch)
+  if (!updateReleaseParameters.target_commitish) {
+    delete updateReleaseParameters.target_commitish
+  }
+
   return updateReleaseParameters
 }